[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 14 Jan 2013 00:39:25 +0100
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Changes to common-opencl.c
On 14 Jan, 2013, at 0:14 , Claudio André <claudioandre.br@...il.com> wrote:
> Em 13-01-2013 18:36, magnum escreveu:
>> Device 1: Tahiti (AMD Radeon HD 7900 Series)
>
> Commited.
Great, I like those little details. It hate having to go to wikipedia to know what a "Loveland" is.
>> For parsing, try to follow how --groups are parsed in options.c and getopt.[ch]. It seems the provided functions can do most things we need. I haven't looked at it now but I'd expect some "documentation" within getopt.h.
>
> I was thinking about creating a function to do something like snipped below. But, seems you meant something else using 'options_main', list_init(), etc. I would prefer to avoid messing with core this way. Could you please clarify?
I can have a go at the parsing if you want. I really think we should use the provided getopt stuff if it can help us at all, and in this case it seems it has exactly the functionality needed.
Given --device=1,2, what should the parser do? Fill an array somewhere?
> BTW: having --device and --devices will disable -de:1 option. Is this ok for everybody?
Not sure what you mean. What will be disabled? Due to how getopt works, --device and --devices will really be the exact same option to John (just like you can say -t instead of --test). So you can just as well say --device=1,2 and --devices=3.
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
