Date: Mon, 6 Aug 2012 05:55:56 +0200 From: Lukas Odzioba <lukas.odzioba@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Current -fixes GPU formats vs TS 2012/8/6 Solar Designer <solar@...nwall.com>: > + for(i=0;i<length;i++) > + salt.salt[i]=tolower(salt.salt[i]); > > Note that the ctype macros including tolower() are defined to accept int > only. They're non-portable/unsafe to use on other than int. > > We have strlwr() (provided by misc.[ch]) and enc_strlwr() (provided by > unicode.[ch]). I don't know which of these is right here. > > Oh, cuda_mscash_fmt.c already uses enc_strlwr() in split(). Perhaps its > salt() should use the same, and you'll probably need to write a NUL to > allow for that. Thanks for pointing this out! I'll use enc_strlwr().
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.