Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Aug 2012 07:47:50 +0400
From: Solar Designer <>
Subject: Re: Current -fixes GPU formats vs TS

On Mon, Aug 06, 2012 at 05:12:30AM +0200, Lukas Odzioba wrote:
> 2012/8/6 magnum <>:
> > form=mscash-cuda                  guesses: 1216 time: 0:00:00:00 :
> > Expected count(s) (1500)  [!!!FAILED!!!]
> Now:
> form=mscash-cuda                  guesses: 1500 time: 0:00:00:05  [PASSED]
> .pot CHK:mscash-cuda              guesses: 1500 time: 0:00:00:05  [PASSED]


+       for(i=0;i<length;i++)
+         salt.salt[i]=tolower(salt.salt[i]);

Note that the ctype macros including tolower() are defined to accept int
only.  They're non-portable/unsafe to use on other than int.

We have strlwr() (provided by misc.[ch]) and enc_strlwr() (provided by
unicode.[ch]).  I don't know which of these is right here.

Oh, cuda_mscash_fmt.c already uses enc_strlwr() in split().  Perhaps its
salt() should use the same, and you'll probably need to write a NUL to
allow for that.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.