Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 15 Jul 2012 08:29:37 -0500
From: "jfoug" <>
To: <>
Subject: RE: Another CVS core bug: Does not load bare hashes

>From: magnum []
>Sent: Sunday, July 15, 2012 4:37 AM
>Subject: [john-dev] Another CVS core bug: Does not load bare hashes
>I believe current CVS core does not load bare hashes. Specifically, the
>CVS core build does not load bare DES and my merged temporary bleeding
>branch does not load bare raw-md5u ones. I will just ignore this until
>fixed in core.

This is due to a change in prepare. Actually, it may be due to a change in loader, but I think it should be changed in each format's prepare statement, since they can get their data from any field.

Before, I think the code would put field 0 into field 1, if there was only 1 field.  I made this simple change to dyanamic's prepare, and things work fine for it.

	char *cpBuilding=split_fields[1];
+	if (!cpBuilding || *cpBuilding==0)
+		cpBuilding = split_fields[0];

So I will see if there are other formats which a 'raw' fails the TS, and make changes where they need to be made.

But that bug should be easy to squash.

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.