Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 14 Jul 2012 11:28:05 +0530
From: Sayantan Datta <>
Subject: Re: opencl_mscash2_fmt.c: clear_keys()

On Thu, Jul 12, 2012 at 7:38 PM, Solar Designer <> wrote:

> opencl_mscash2_fmt.c's clear_keys() doesn't appear to serve a useful
> purpose.  Did you add it for a specific reason or just because it was
> supported by the formats interface?  I think fmt_default_clear_keys (a
> no-op) would work just as well, but faster.

> Zeroizing of dcc2_hash_host (the computed hashes) in clear_keys() is
> especially weird because this is a salted format, whereas clear_keys()
> is only called before/after having tried the keys for all salts, not
> between salts.  So the hashes stayed non-zeroized in most cases anyway,
> and thus your code shouldn't have relied on them being zeroized anyway.

Yes I did that because I thought that absence of the clear keys might
interfere with the TS. But it doesn't. I would remove that whenever I get
time and access to a proper computer this week because I'm a little busy
with university stuff.


Content of type "text/html" skipped

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.