Date: Mon, 09 Jul 2012 22:44:57 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: magnum-jumbo and magnum-bleeding (NOT J7), and the source() function On 2012-07-09 17:50, jfoug wrote: > What direction should the fmt.methods.source() (currently named get_source) > function take? > > I would propose this. > > 1. Rename it to source() (how Solar wants it). Also change any > documentation, and -list= data to reference source > > 2. Move it to right after salt, this would be a more 'fitting' > location. Currently in bleeding, it is at the bottom of the structure, but > I simply put it there to get NULL pointers during early implementation, so I > would not have to modify every _fmt.c file. Fine with me. > 3. Get jumbo-bleed updated with these changes. > > 4. Move these changes into magnum-jumbo (since we have a Jumbo-7RC > branch of git). Once this is done, bleeding and jumbo should be back to > being much more 'similar' to each other. Thinks that should be in magnum-jumbo should enter the tree in magnum-jumbo, and propagate to bleeding. The other way round works too but is trickier to merge, and history looks weird afterwards (patches listed twice). magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.