Date: Fri, 6 Jul 2012 10:16:39 +0200 From: Frank Dittrich <frank_dittrich@...mail.com> To: john-dev@...ts.openwall.com Subject: Re: KRB4: fix memset in afs_cmu_StringToKey() On 07/06/2012 10:02 AM, Frank Dittrich wrote: > clang 3.0 correctly identified a problem here and issued a warning > [-Wsizeof-pointer-memaccess] > > On linux-x86 (32bit), sizeof(key) is just 4, while sizeof(*key) is 8. > > Attached patch fixes the problem. Since the code was copied from somewhere else, should this be reported to upstream? According to the git blame, magnum added that code. But git log rather suggests he applied patches from the wiki page or from somewhere else: commit de989e6e12f48090f1b3dd095ea327ed8a2df30e Author: magnum <magnum> Date: Wed Nov 9 12:20:47 2011 +0100 john-1.7.9-jumbo-1 (1.7.8-jumbo-8 equivalent) Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.