[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 06 Jul 2012 00:34:18 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: Make some more --list= commands work despite a broken
config
On 2012-07-05 14:50, Frank Dittrich wrote:
> I tried
>
> $ ./john --list=formats
>
> for an older binary (not *that* old:1.7.9-jumbo-6), and got:
>
> Error, unknown flag: Flag=MGF_FULL_CLEAN_REQUIRED
> Error parsing section [List.Generic:dynamic_1003]
> Error in line 63 file is ./dynamic.conf
>
> $ echo $?
> 1
>
> The only --list= commands that work are
>
> --list=?
> --list=build-info
> --list=hidden-options
>
> After compiling a new binary, and changing that line 63 in dynamic-conf
> to simulate a newly introduced flag, I verified that this option works
> as well (as expected):
>
> --list=help[:WHAT]
>
> This option should also work, because there is no need to read the config:
>
> $ ./john --list=encodings
> Error, unknown flag: Flag=MGF_BUG_BUG_BUG
> Error parsing section [List.Generic:dynamic_1003]
> Error in line 63 file is ./dynamic.conf
>
> I can't test --list=opencl-devices and --list=cuda-devices,
> but I think it is the same here (I had a look at the code). Currently
> these formats will fail, but they shouldn't.
>
> That's why the attached patch moves processing these 3 --list= options
> further up, so that the config is read afterwards.
Committed. Am I done for today?
magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
