Date: Tue, 26 Jun 2012 03:17:24 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: FMT_UNICODE and FMT_UTF8 flags On 2012-06-26 02:00, Solar Designer wrote: > On Tue, Jun 26, 2012 at 01:32:58AM +0200, magnum wrote: >> Formats that are UCS-2 internally >> (like these) must set FMT_UNICODE and as long as they do not really >> support encodings other than ISO-8859-1 they must not set FMT_UTF8. > > Is this documented anywhere? The comments in formats.h don't make it > clear that not setting these flags may have drastic consequences like > what you describe. I made the comments more clear now. They were probably from first versions of the UTF-8 patch in 2009 and their meaning has skewed a little (FMT_UTF8 should really be FMT_ENCODING nowadays). I had thoughts about writing a "doc/Unicode-programming" with some hints but I doubt anyone would read it. The best we have right now is unicode.h so I added a note there to watch out for these flags. magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.