Date: Mon, 25 Jun 2012 01:23:36 +0200 From: Frank Dittrich <frank_dittrich@...mail.com> To: john-dev@...ts.openwall.com Subject: doc/DYNAMIC (was: don't #include <omp.h> unless defined(_OPENMP)) On 06/24/2012 11:23 PM, Solar Designer wrote: > We shouldn't try to #include <omp.h> unless we're actually making an > OpenMP-enabled build. The attached patch fixes the issue reported here: > > http://blog.thireus.com/john-the-ripped-steak-and-french-fries-with-salt-and-pepper-sauce-for-hungry-password-crackers He shouldn't have used dynamic_66 anyway; Since mentioning this in doc/DYNAMIC doesn't seem to be good enough, should we also add a comment mentioning that names up to dynamic_999 are reserved? The patch does that for dynamic.conf. I also noticed that the documentation for dynamic formats wasn't really up to date. I tried to improve that a little bit with my patch. Please have a look. Probably more can be done here. Some of the Examples included in doc/DYNAMIC are syntactically not correct, and john will complain about errors: (But may be the errors existed for a long time, and we have more important errors to fix.) $ ./john --test=0 Error, unknown function: Func=DynamicFunc__SHA1_crypt_md5_input1_append_input2_base16 Error parsing section [List.Generic:dynamic_1062] Error in line 1638 file is ./john.local.conf After commenting out that one: $ ./john --list=subformats Error, unknown function: Func=DynamicFunc__SHA1_crypt_md5_input2_to_output1_FINAL Error parsing section [List.Generic:dynamic_1063] Error in line 1654 file is ./john.local.conf BTW, [List.Generic:dynamic_1062] and [List.Generic:dynamic_1063] both appear twice in doc/DYNAMIC. 1064 is incorrect as well. $ ./john --list=subformats Error, unknown function: Func=DynamicFunc__SHA1_crypt_md5_input1_to_output1_FINAL Error parsing section [List.Generic:dynamic_1064] Error in line 1665 file is ./john.local.conf BTW, if I just comment out the line Func=DynamicFunc__SHA1_crypt_md5_input1_to_output1_FINAL and delete all other formats after dynamic_1064, ./john --test=0 --format=dynamic_1064 will segfault. And so on. May be for jumbo-6, I'll just add a cleanup patch deleting the incorrect examples from doc/DYNAMIC. If someone wants to add correct examples, this should be easy by fetching the old revision. Frank View attachment "0001-Some-documentation-fixes-for-dynamic-formats.patch" of type "text/x-patch" (6006 bytes)
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.