Date: Wed, 20 Jun 2012 09:16:21 +0200 From: Lukas Odzioba <lukas.odzioba@...il.com> To: john-dev@...ts.openwall.com Subject: Re: EPiServer 2012/6/18 Solar Designer <solar@...nwall.com>: > Dhiru - > > episerver_fmt_plug.c supports both the SHA-1 and the SHA-256 based > flavor of these hashes, however the test vectors are only for SHA-1. > > This needs to be corrected. Since it will affect benchmark speeds, > we'll need to reflect the number of test vectors of each type in the > benchmark comment. I do not know exactly how john's benchmark procedure looks like, but can't we use only first test vector for benchmarking, and all of them for correctness checking? Or we could add another test vector group to fmt interface only for benchmarking purposes. Of course additional code is required but we could gain: - benchmark results comparability between different code versions - utilization all of those commented tests vectors But still, benchmarking is not a very important feature. Lukas
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.