[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4E483E00.2010801@bredband.net>
Date: Sun, 14 Aug 2011 23:28:32 +0200
From: magnum <rawsmooth@...dband.net>
To: john-dev@...ts.openwall.com
Subject: Re: Problems with the 0007 patch
I do not think your fix was busted, it was just fixed for the case of
xBuf != 1
So if your fix ever worked for sequential buffers (xBuf=1), it will now
also work for interleaved ones.
I'm more worried about the 0010 patch. Did that break something? I
*think* it should not.
magnum
On 2011-08-14 22:56, JimF wrote:
> The NT/cash1 were bug fixes I did. If there is U+0080 in the text
> stream, the key loading helpers will scrub the rest of the word.
>
> Thus, my fix is also busted. I am trying to catch up on email, so it may
> be that by the time I read all the emails I have stacked, this issue may
> have been resolved.
>
> Jim.
>
> From: "magnum" <rawsmooth@...dband.net>
>
>> The NT problem is trivial. In get_key_helper()
>>
>> - if (key[md4_size] == 0x80 && ((keybuffer[i+1]&0xFFFF) == 0 ||
>> md4_size == PLAINTEXT_LENGTH)) {
>> + if (key[md4_size] == 0x80 && ((keybuffer[i+xBuf]&0xFFFF) == 0 ||
>> md4_size == PLAINTEXT_LENGTH)) {
>
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
