Date: Mon, 09 May 2011 21:24:02 +0200 From: magnum <rawsmooth@...dband.net> To: john-dev@...ts.openwall.com Subject: Re: Plumbing changes (moved from john-users) On 2011-05-07 21:48, magnum wrote: > On 2011-05-07 00:20, magnum wrote: >> Maybe I should also implement that "auto-generated format list" for >> options.c that I have been thinking about... this would mitigate a lot >> of patch collisions. Together with your changes, most new formats would >> only add one line in Makefile and two in john.c > > That was much easier than I feared. I did have to move the > john_register_all() call in john.c main() so the formats are loaded when > calling opt_init(). I hope this won't break anything? When applied to the Jumbo-2RC, the output is like this: --format=NAME force hash type NAME: md5-gen/md5-gen/md5-gen/md5-gen/md5-gen/md5-gen md5-gen/md5-gen/md5-gen/md5-gen/md5-gen/md5-gen md5-gen/md5-gen/md5-gen/md5-gen/md5-gen/md5-gen md5-gen/md5-gen/md5-gen/md5-gen/md5-gen/md5-gen md5-gen/md5-gen/md5-gen/md5-gen/md5-gen/des/bsdi/md5 bf/afs/lm/nt/xsha/mscash/mscash2/hmac-md5/po/raw-md5 raw-md5-unicode/phpass-md5/dmd5/ipb2/raw-sha1 sha1-gen/raw-md4/md4-gen/krb4/krb5/mskrb5/nsldap ssha/openssha/bfegg/oracle/oracle11/mysql/mysql-sha1 lotus5/dominosec/netlm/netntlm/netlmv2/netntlmv2 nethalflm/mschapv2/mssql/mssql05/epi/phps/mysql-fast pix-md5/sapg/sapb/md5ns/hdaa/crypt/dummy This did not happen with Jumbo-1. So, what should I do here? Mute all md5-gen's except the first? Or mute all of them and add one manually as the LAST format because the very next text in the output deals about subformats? magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.