Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 17 Nov 2014 11:05:08 +0100
From: John Spencer <maillist-busybox@...fooze.de>
To:  sabotage@...ts.openwall.com
Subject: Re: [PATCH] Edited cmus pkgbuild for new version and added
 mutt

Henrique Lengler wrote:
> Hi,
> 
> I edited the cmus pkgbuild to get a new version .
> And I added a pkgbuild to mutt.
> 
> The two files are attached.

thanks! you're using raw git patches, but i'd prefer if you could open a 
pull request on github, or send full git patches so we have proper 
author information.
to create git patches, make one commit per change. in this case you'd 
have 2 commits, one for cmus and one for mutt, and afterwards you can 
use "git format-patch HEAD~X" where X is the number of commits, in this 
case 2). that will spit out 2 patches that are properly formatted for 
usage with "git am".

> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/pkg/mutt b/pkg/mutt
> new file mode 100644
> index 0000000..29e7aad
> --- /dev/null
> +++ b/pkg/mutt
> @@ -0,0 +1,21 @@
> +[main]
> +filesize=3782032
> +sha512=f1b4a7230253651857f61bd7215cce870a613012f613d4c907d401556083726c8ed7d429d57a8bf858c3b5b23683380d4c1494540d86ca80813e22cb6b95bc1e
> +tardir=mutt-1.5.23
> +
> +[mirrors]
> +http://downloads.sourceforge.net/project/mutt/mutt/mutt-1.5.23.tar.gz
> +
> +[deps]

doesn't this need openssl in deps and whatever provides sasl ?

> +
> +[build]
> +CFLAGS="$optcflags" LDFLAGS="$optldflags" \
> +./configure --prefix="$butch_prefix" \
> +--enable-imap \
> +--enable-smtp \
> +--with-ssl  \
> +--with-sasl  \
> +--with-homespool=/var/spool/
> +
> +make -j$MAKE_THREADS
> +make DESTDIR="$butch_install_dir" install
> 
> 
> ------------------------------------------------------------------------
> 
> diff --git a/pkg/cmus b/pkg/cmus
> index 8fce27d..1a18c5e 100644
> --- a/pkg/cmus
> +++ b/pkg/cmus
> @@ -1,14 +1,19 @@
>  [main]
> -filesize=224675
> -sha512=a43e976dd7ca39d576ae51b0f66f9bc4fa21f30626cb814fa237389c9bbc1c0b5a3a28b1d3d0d86527c3a3ffb771cc68d29d5ca8b88f0390bda7926e668504e4
> +filesize=287834
> +sha512=737ee38886f449aa67b105e170aaa3ef3f7f5dff9be079ff92817e9f249f4e0a88e78a190e8a0ccae1c6be8a11fa954df5b59592472bbb795c36197d2b377dd8
> +tardir=cmus-2.6.0
>  
>  [mirrors]
> -http://downloads.sourceforge.net/project/cmus/cmus-v2.5.0.tar.bz2
> +http://github.com/cmus/cmus/archive/v2.6.0.tar.gz
>  
>  [deps]
> +libvorbis

likewise, i think this needs alsa-lib in deps since you're explicitly 
enabling it

>  
>  [build]
>  CFLAGS="$optcflags" LDFLAGS="$optldflags" \
> -./configure prefix="$butch_prefix"
> -make -j$MAKE_THREADS
> -make DESTDIR="$butch_install_dir" install
> +./configure prefix="$butch_prefix" \
> +CONFIG_VORBIS=y \
> +CONFIG_ALSA=y
> +
> +make -j$MAKE_THREADS 
> +make DESTDIR="butch_install_dir" install

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.