Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 15 Apr 2019 18:18:56 -0400 (EDT)
From: Unit 193 <unit193@...ntu.com>
To: Solar Designer <solar@...nwall.com>
cc: passwdqc-users@...ts.openwall.com, Jackson Doak <noskcaj@...ntu.com>
Subject: Re: Manpage formatting patch

Howdy,

On Mon, 15 Apr 2019, Solar Designer wrote:

> Hi,
>
> On Mon, Apr 15, 2019 at 06:04:33AM -0400, Unit 193 wrote:
>> A while ago, the Debian maintainer (Jackson Doak) noticed a formatting
>> error in the manpage of pwqcheck and patched the Debian package, as this
>> problem still exists upstream I'm forwarding the patch inline to you.
>
> Thank you!  However, the original is somehow rendered correctly for me:
>
>     -1      Read just 1 line (new passphrase).  This is needed to use
>             pwqcheck as the passwordcheck program on OpenBSD - e.g., with
>             ":passwordcheck=/usr/bin/pwqcheck -1:\" in the "default" section
>             in /etc/login.conf.
>
> Is this not how it was getting rendered on Debian prior to the patch?

That's pretty much how it would appear, but the manpage linter would emit 
'hyphen-used-as-minus-sign' as historically those were treated differently.

I can't say for certain if it's still misinterpreted anywhere, but I figured I'd 
forward the patch in case it is relevant.

>> In addition to thepatch below, it looks like you have an excess backslash
>> in the example given,
>
> No, that backslash is part of the target file's syntax, and is correct.

Ah, my apologies!  With the opening quote unescaped I figured there was a typo 
somewhere.

>> as that is rendered by man.
>
> This is correct.
>
>> Description: Fixes minor glitches in the manpages
>> Author: Jackson Doak <noskcaj@...ntu.com>
>>
>> Index: passwdqc-1.3.0/pwqcheck.1
>> ===================================================================
>> --- passwdqc-1.3.0.orig/pwqcheck.1	2013-08-10 16:55:41.127266666 +1000
>> +++ passwdqc-1.3.0/pwqcheck.1	2013-08-10 16:55:41.127266666 +1000
>> @@ -160,7 +160,7 @@
>>  This is needed to use
>>  .Nm
>>  as the passwordcheck program on OpenBSD - e.g., with
>> -":passwordcheck=/usr/bin/pwqcheck -1:\\"
>> +":passwordcheck=/usr/bin/pwqcheck \-1:\\"
>>  in the "default" section in
>>  .Cm /etc/login.conf .
>>  .It Cm -2
>
> Speaking of Debian package maintenance, any plans to update to 1.3.1?
> We released 1.3.1 in 2016 in response to a bug reported via Debian, but
> somehow Debian itself didn't care to update nor fix the bug:
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=831356

The reason I forwarded the patch is because I have an updated passwdqc 1.3.1 
ready to go, I just haven't contacted the maintainer yet to see if he's still 
active, working on it, would be interested in pushing what I have, or 
transferring the package to me.

As it stands, Debian is in freeze for the next stable release so nothing would 
be moving forward right this moment anyway.


~Unit 193
Unit193 @ freenode
Unit193 @ OFTC

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.