Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110316231540.GA9926@openwall.com>
Date: Thu, 17 Mar 2011 02:15:40 +0300
From: Solar Designer <solar@...nwall.com>
To: owl-dev@...ts.openwall.com
Subject: Re: VLANs in Owl way?

On Wed, Mar 16, 2011 at 11:54:21PM +0100, Piotr Meyer wrote:
> Attachment contains latest diff (with suggested changes in regexp and
> proper support for vlan[0-9]{1,4} format). Is this patch correctly 
> formatted?

Yes, it is.  Thanks!

> > Besides changes to the scripts, maybe you need to add documentation?
> 
> I add few words to sysconfig.txt, is this enough?

Yes, it's enough for now.

>      # this is broken! it's only here for compatibility with old RH systems
> -    if [ "${GATEWAY}" != "" -a "${GATEWAY}" != "none" ]; then
> -	route add default gw ${GATEWAY} metric 1 ${DEVICE}
> -    fi
> -
> -    . /etc/sysconfig/network
> +    #if [ "${GATEWAY}" != "" -a "${GATEWAY}" != "none" ]; then
> +    #	route add default gw ${GATEWAY} metric 1 ${DEVICE}
> +    #fi

Why are you commenting out the default route setup?  This change looks
wrong to me.
 
Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.