[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d1bda7f6-2762-4f2e-ac36-0825f19f2745@gmail.com>
Date: Sun, 1 Mar 2026 22:56:51 -0500
From: Demi Marie Obenour <demiobenour@...il.com>
To: oss-security@...ts.openwall.com, Florian Weimer <fweimer@...hat.com>,
Alan Coopersmith <alan.coopersmith@...cle.com>
Subject: Re: OSEC-2026-01 in the OCaml runtime: Buffer
Over-Read in OCaml Marshal Deserialization
On 2/27/26 14:39, Florian Weimer wrote:
> * Alan Coopersmith:
>
>> https://sympa.inria.fr/sympa/arc/ocsf-ocaml-security-announcements/2026-02/msg00000.html
>> announces:
>>> From: Hannes Mehnert <hannes@...nert.org>
>>> To: ocsf-ocaml-security-announcements@...ia.fr
>>> Subject: [ocsf-ocaml-security-announcements] OSEC-2026-01 in the OCaml runtime: Buffer Over-Read in OCaml Marshal Deserialization
>>> Date: Tue, 17 Feb 2026 15:16:54 +0100
>>> Dear everyone,
>>> it is my pleasure to announce the first security announcement of
>>> this year,
>>> and the first on this mailing list.
>>> It should any moment now also appear at
>>> https://osv.dev/list?q=OSEC-2026-01
>>> Human link:
>>> https://github.com/ocaml/security-advisories/tree/main/advisories/2026/OSEC-2026-01.md
>
> Surprised to read this. I think this comment from 2018 is still
> appropriate:
>
> | Marshal should not used in contexts where an attacker can control the
> | data. I don't believe it is, at least in any project I'm aware of, and
> | if it were, it's unlikely that those project perform enough check on
> | the result of Marshal to make the use safe anyway.
>
> <https://github.com/ocaml/ocaml/issues/7765#issuecomment-473076288>
>
> The demarshaller does not have access to type information from the
> program, so it has the ability to construct an arbitrary object graph.
That is indeed true. However, unlike in many other languages, this
does not directly allow arbitrary code execution. The only third-party
code that runs during unmarshalling is the C code responsible for
unmarshalling custom blocks. One of the vulnerabilities was that
this code did not have enough information to validate its inputs.
> The manual has a formatting glitch which hides the last sentence quoted
> below:
>
> | Warning: marshaling is currently not type-safe. The type of marshaled
> | data is not transmitted along the value of the data, making it
> | impossible to check that the data read back possesses the type
> | expected by the context. In particular, the result type of the
> | Marshal.from_* functions is given as 'a, but this is misleading: the
> | returned OCaml value does not possess type 'a for all 'a; it has one,
> | unique type which cannot be determined at compile-time. The programmer
> | should explicitly give the expected type of the returned value, using
> | the following syntax:
> |
> | (Marshal.from_channel chan : type)
> |
> | Anything can happen at run-time if the object in the file does not
> | belong to the given type.
>
> <https://ocaml.org/manual/5.4/api/Marshal.html>
>
> And the party supplying the serialized blob can chose whether the type
> matches. So the inherent insecurity of unmarshalling (“Anything can
> happen”) is actually documented, just not very clearly.
My reading is that unmarshalling untrusted input should be safe: the
runtime should either throw an exception or return a well-formed value.
What is *not* safe is using the returned value without validating
it first. One can use functions in the `Obj` module to do this.
I do question if there are any programs in the wild that accept
untrusted marshalled data and do sufficient validation to be secure
without this. Marshalled data is not guaranteed to be portable
between versions of OCaml, which severely limits the usefulness of
doing so. Also, the format is not documented.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Download attachment "OpenPGP_0xB288B55FFF9C22C1.asc" of type "application/pgp-keys" (7141 bytes)
Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists
Please check out the
Open Source Software Security Wiki, which is counterpart to this
mailing list.
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
