Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 2 Jul 2018 16:10:24 +0200
From: Jakub Wilk <>
Subject: Re: accountsservice: insufficient path check in

* Matthias Gerstner <>, 2018-07-02, 14:21:
>I think the easiest way to fix this is to normalize the user supplied 
>filename e.g. using realpath()

Using realpath(3) for access control is almost always a mistake: this 
function expands symlinks, including attacker-controlled symlinks.

You patch uses g_file_get_path(), which AFIACT doesn't use any 
filesystem I/O for canonicalisation, so that should be fine.

Jakub Wilk

Powered by blists - more mailing lists

Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.