Date: Wed, 9 Oct 2013 18:48:01 +0200 From: Bas Pape <baspape@...il.com> To: oss-security@...ts.openwall.com Subject: CVE Request - Quassel IRC SQL injection Hi all, Please assign a CVE to the following issue: Quassel IRC is vulnerable to SQL injection on all current versions (0.9.0 being the latest at the time of writing), if used with Qt 4.8.5 (the vulnerability is caused by a change in its postgres driver[1,2]) and PostgreSQL 8.2 or later with standard_conforming_strings enabled (which is the default in those versions). The vulnerability allows anyone to trick the core into executing SQL queries, which includes cascade deleting the entire database. It is tracked upstream in bug #1244 . It was firstly noticed by due to minor issues with migration to postgres and problems with certain messages, a simple test with an unmodified installation of postgres and quassel showed that it was indeed possible to drop tables. No upstream fix is available at this time, although the below patch does fix the current issue. Regards, Bas Pape (Tucos)  https://qt.gitorious.org/qt/qtbase/commit/e3c5351d06ce8a12f035cd0627356bc64d8c334a  https://bugreports.qt-project.org/browse/QTBUG-30076  http://bugs.quassel-irc.org/issues/1244 commit 7c64ed0d05718d907770d11a38436aa4ed65f2bb Author: Bas Pape <baspape@...il.com> Date: Mon Oct 7 19:51:52 2013 +0200 Detect the need for standard_conforming_strings. diff --git a/src/core/postgresqlstorage.cpp b/src/core/postgresqlstorage.cpp index 3965704..70bf894 100644 --- a/src/core/postgresqlstorage.cpp +++ b/src/core/postgresqlstorage.cpp @@ -101,6 +101,15 @@ void PostgreSqlStorage::initDbSession(QSqlDatabase &db) // this blows... but unfortunately Qt's PG driver forces us to this... db.exec("set standard_conforming_strings = off"); db.exec("set escape_string_warning = off"); + + // Fortunately things can always blow more. Refer to the commit message for + // the juicy details, tread lightly. + // First standard_conforming_strings are turned off, because that's what used + // to be necessary, here the actual behaviour is tested. + QSqlQuery query = db.exec("SELECT '\\\\' x"); + if (query.first()) + if (query.value(0).toString() == "\\") + db.exec("set standard_conforming_strings = on"); }
Powered by blists - more mailing lists
Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.