Date: Tue, 22 Nov 2011 17:18:43 -0500 From: Marc Deslauriers <marc.deslauriers@...onical.com> To: oss-security@...ts.openwall.com Subject: Re: Re: [LightDM] Version 1.0.6 released On Tue, 2011-11-22 at 22:39 +0100, Yves-Alexis Perez wrote: > On ven., 2011-11-11 at 13:27 -0500, Marc Deslauriers wrote: > > On Fri, 2011-11-11 at 10:05 +0000, John Haxby wrote: > > > On 11/11/11 08:06, Guido Berhoerster wrote: > > > > Replacing the file between the lstat and the open would change > > > > its inode and then be caught by the check before the fchown, no? > > > > > > Nope. There is no reason why the same inode should not be reused. > > > > > > On ext4 (btrfs seems to be different): > > > > > > $ touch test; ls -i test; rm test; touch test; ls -i test > > > 656078 test > > > 656078 test > > > > > > jch > > > > How about the attached patch? > > > > Marc. > > Note that O_NOFOLLOW seems to be Linux-only. Any idea how to handle it > on other ports? It should be available on kFreeBSD also, isn't it? Honestly, you can probably just remove that whole section of code. It's only there to handle a bug in old versions of lightdm that incorrectly created the ~/.Xauthority file as root. Marc.
Powered by blists - more mailing lists
Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.