Date: Tue, 8 Mar 2011 15:07:30 +0100 From: Tomas Hoger <thoger@...hat.com> To: oss-security@...ts.openwall.com Subject: Re: CVE request, php's shm On Tue, 8 Mar 2011 14:36:49 +0100 Pierre Joye wrote: > This flaw has been discovered by Jose Carlos Norte, already fixed in > SVN by Felipe Pena (felipe@....net), see > http://svn.php.net/viewvc/?view=revision&revision=309018 It may be more readable to use the check as: if (count < 0 || count > shmop->size - size) Previous size check gives you guarantees regarding shmop->size - size result. Just my 2c. -- Tomas Hoger / Red Hat Security Response Team
Powered by blists - more mailing lists
Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.