Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 08 Apr 2010 14:02:13 -0500
From: Jamie Strandboge <>
Subject: Re: CVE request -- memcached

On Thu, 2010-04-08 at 11:57 -0500, Jamie Strandboge wrote:
> People wanting to fix this may want to more thoroughly look at the
> patch[1]. After a cursory glance at it, I'm not sure it is enough:
> 1. it uses:
>   if (strcmp(ptr, "get ") && strcmp(ptr, "gets ")) {
> Why not use something like (*totally* untested):
>   if (strncmp(ptr, "get ", 5) && strncmp(ptr, "gets ", 5)) {
> just in case ptr is not NULL terminated? I haven't checked if this is an
> actual issue, but it certainly wouldn't hurt. '5' should probably be
> changed to something more reasonable.

FYI, looks like upstream decided to use strncmp after all:

Jamie Strandboge             |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)

Powered by blists - more mailing lists

Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.