Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 16 Mar 2010 14:41:52 +0100
From: Peter Sylvester <Peter.Sylvester@...lweb.fr>
To: oss-security@...ts.openwall.com
Cc: Brian Stafford <brian@...fford.uklinux.net>,
	libesmtp@...fford.uklinux.net, security@...ntu.com,
	Pawel Salek <pawsa@...ochem.kth.se>, jskarvad@...hat.com
Subject: Re: CVE Request: libesmtp does not check NULL bytes
 in commonName


> 
> Doesn't that lack a null byte check for subjAltNames?
> 

The patch seems broken to me:
X509_NAME_get_text_by_NID gets the "highest" one, not the leaf value.
In case of two common names, this is wrong.

So instead of
int l = X509_NAME_get_text_by_NID (X509_get_subject_name (cert),
                             NID_commonName, buf, sizeof buf);

one needs something like:

    X509_NAME *name = X509_get_subject_name(cert) ;
     if(name)
       while((j=X509_NAME_get_index_by_NID(name,NID_commonName,i))>=0)
         i=j;



Powered by blists - more mailing lists

Your e-mail address:

Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.