Date: Sat, 22 Nov 2008 17:49:40 +0100 From: Thomas Viehmann <tv@...mnet.de> To: oss-security@...ts.openwall.com CC: 498243@...s.debian.org, xine-user@...ts.sourceforge.net, redpig@...rt.org Subject: xine-lib and ocert-2008-008 [resending this with hopefully less broken CC, apologies] Hi, I am not quite sure whether I can agree with Will Drewry's analysis accompanying ocert advisory 2008-008. Looking at item 1A, which Will says is fixed in 1.1.5, attached .mov seems to fit the case description and will still corrupt the memory when viewed e.g. in gxine. xine-lib with the attached patch seems to be more successful in preventing the attach (note that the file is more tuned to be small than to be a valid .mov, but the same works by including the bad meta in an otherwise good file). Note that xine_xmalloc is specifically designed to allocate memory when passed size 0. Upstream seems to move away from it, but... As Will notices, demux-qt.c has loads of unfixed problems. If anyone cares to go over the xine-lib issues (primarily the unfixed ones from Will's section 3), I'd much appreciate a CC. In order to make the analysis and verification more, I would also be interested in the test cases mentioned in the advisory. Kind regards T. 1. http://www.ocert.org/analysis/2008-008/analysis.txt 2. http://www.ocert.org/advisories/ocert-2008-008.html -- Thomas Viehmann, http://thomas.viehmann.net/ View attachment "fix-for-ocert-2008-008-1a.diff" of type "text/x-patch" (2496 bytes)
Powered by blists - more mailing lists
Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.