Date: Thu, 4 Sep 2008 17:17:57 +0200 From: Nico Golde <oss-security+ml@...lde.de> To: oss-security@...ts.openwall.com Subject: Re: CVE Request (gpicview) Hi, * Robert Buchholz <rbu@...too.org> [2008-09-03 11:22]: > On Sunday 31 August 2008, Nico Golde wrote: > > Same piece of code main-win.c doesn't look too trustworthy > > to me either: > > > > 690 int error = jpegtran (filename, "/tmp/rot.jpg" , code); > > 691 if(error) > > 692 return error; > > 693 > > 694 //now copy /tmp/rot.jpg back to the original file > > 695 char command[strlen(filename)+50]; //this should not > > generate buffer owerflow 696 // MS: didn't know, how to make it > > better, maybe an own copy routine 697 sprintf(command,"cp > > /tmp/rot.jpg \"%s\"",filename); 698 system(command); > > > > Anyone played with crafted file names? > > Good catch! You need to append '.jpg' at the end of the crafed filename > so the rotation via jpegtran is invoked, but besides that it works ok: [...] Can we get a second CVE id for this then please? Kind regards Nico -- Nico Golde - http://www.ngolde.de - nion@...ber.ccc.de - GPG: 0x73647CFF For security reasons, all text in this mail is double-rot13 encrypted. Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists
Please check out the Open Source Software Security Wiki, which is counterpart to this mailing list.
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.