Date: Wed, 5 Aug 2020 18:27:20 +0200 From: Solar Designer <solar@...nwall.com> To: lkrg-users@...ts.openwall.com Subject: Re: lkrg: Fix build LKRG for kernel 5.8+ On Wed, Aug 05, 2020 at 05:12:54PM +0200, Mikhail Morfikov wrote: > It looks like that lkrg for 5.8 also can't be built: Oops. That's what I get for improvising without testing on more than one system. Mikhail Klementev would rightly remind us that we should start using his https://github.com/jollheef/out-of-tree or some other Continuous Integration setup. Build on new kernels should be fixed now. I tested on two systems this time. ;-) Please test it on Linux 5.8, which I don't have anywhere yet. commit 8d926b99fea47fa01e1d563b2ae71fb21cc42867 Author: Solar Designer <solar@...nwall.com> Date: Wed Aug 5 18:19:32 2020 +0200 Fix build with non-RHEL kernels broken with the previous commit commit b459b334e6a1020732541840957ffefb2d1873df Author: Solar Designer <solar@...nwall.com> Date: Tue Aug 4 21:48:36 2020 +0200 Don't include linux/cryptohash.h on recent kernels This fixes LKRG build on Linux 5.8+, which renamed that header file. Thanks to Andy Lavr for reporting this problem and suggesting a (different) fix, which made us revisit our use of that header file. We only need that header file on older kernels (< 4.4.72 or < RHEL 7.4) for the one use of md5_transform() in get_random_long(). On newer kernels, we simply use the kernel-provided get_random_long(). Further, 5.8's crypto/sha.h doesn't declare md5_transform() anyway (linux/cryptohash.h on much older kernels did). Thanks, Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.