Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 6 Feb 2022 22:49:40 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"Paul E . McKenney" <paulmck@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>,
	"H . Peter Anvin" <hpa@...or.com>, Paul Turner <pjt@...gle.com>,
	linux-api@...r.kernel.org,
	Christian Brauner <christian.brauner@...ntu.com>,
	Florian Weimer <fw@...eb.enyo.de>, David.Laight@...lab.com,
	carlos@...hat.com, Peter Oskolkov <posk@...k.io>,
	libc-coord@...ts.openwall.com
Subject: Re: [RFC PATCH 1/3] rseq: Introduce feature size and alignment ELF
 auxiliary vector entries

On Thu, Feb 03, 2022 at 02:38:51PM -0500, Mathieu Desnoyers wrote:

> @@ -286,6 +287,10 @@ create_elf_tables(struct linux_binprm *bprm, const struct elfhdr *exec,
>  	if (bprm->have_execfd) {
>  		NEW_AUX_ENT(AT_EXECFD, bprm->execfd);
>  	}
> +#ifdef CONFIG_RSEQ
> +	NEW_AUX_ENT(AT_RSEQ_FEATURE_SIZE, offsetof(struct rseq, end));

I've gotta ask, what's up with offsetof(, end) vs sizeof() ?

> +	NEW_AUX_ENT(AT_RSEQ_ALIGN, __alignof__(struct rseq));
> +#endif

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.