Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 6 Jul 2016 17:32:53 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: rules.c bug/feature

On 2016-07-06 17:27, magnum wrote:
> -                       memcpy(in + length, in, length);
> +                       if (rules_max_length - length > 0)
> +                               strnzcpy(in + length, in,
> +                                        rules_max_length - length);
>                         in[length <<= 1] = 0;
>                         break;

Correction: Obviously the "in[length <<= 1] = 0;" line should change 
too. We no longer need to null terminate but we need to update length 
properly to whatever it ended up as.

magnum

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.