Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 3 Dec 2015 14:22:07 -0600
From: jfoug <>
Subject: Re: rules.c patch for ASan fault

Is there really a reason for the (int)  ??  If not, then simply replace 
it with (unsigned char) and be done with it.   The compiler will up-cast 
the unsigned char from the inner expression into an int before doing the 
subtraction, even without the cast.

On 12/3/2015 2:11 PM, Solar Designer wrote:
> On Thu, Dec 03, 2015 at 02:06:50PM -0600, jfoug wrote:
>> How about this change:
> This is what I was about to commit, just without the extra braces.
> Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.