Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 19 Oct 2015 23:40:42 +0300
From: Solar Designer <>
Subject: Re: db built from test vectors

Hi magnum,

On Mon, Oct 19, 2015 at 12:57:10AM +0200, magnum wrote:
> I'm not yet sure about all details on how we should use this or what 
> more changes need be made to core code but I reckoned I should give you 
> a heads-up.

I appreciate this.

> Since July, we always pass the real db to reset() if we have one. This 
> was added for Agnieszka. With the above we could pass the fake db when 
> we don't have any db. I guess we also need to pass db->salts in all 
> crypt_all() calls - or perhaps only in benchmark. If we do so in 
> self-test before a real crack run, we probably need to reset(fake db) 
> before self-tests and reset(real db) after it. But that may collide with 
> Agnieszka's needs, I'm not sure.

This would be a change to how the formats interface is defined, as IIRC
it would go against what the comments in formats.h currently say.

> Perhaps we should not change test/benchmark at all but instead use this 
> feature in format code as needed. Sayantan's formats could set a 
> format-global pointer to fake_db in reset(), and when crypt_all is 
> called with a NULL salt, we can use fake_db->salt instead.

This might be a hack, but it does appear to avoid changing the formats
interface definition.

> We'll see where things lead. Perhaps you have some thoughts or ideas?

I am not sure either.  Unfortunately, my head is full with other
projects now, so I'll let you try to figure this out.  But like I said,
I appreciate the heads-up.


Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.