Date: Sat, 19 Sep 2015 03:02:09 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: vloadu_emu() On 08/09/15 16:33, Lei Zhang wrote: > On Sep 8, 2015, at 8:10 PM, Solar Designer <solar@...nwall.com> wrote: >> >> magnum, >> >> Do we really need to use the comma operator here? - >> >> return (memcpy(buf, addr, MEM_ALIGN_SIMD), vload(buf)); >> >> I think not. I suggest that we change this to: >> >> memcpy(buf, addr, MEM_ALIGN_SIMD); >> return vload(buf); >> >> With the comma operator, I first misread this code as returning pointer >> to a buffer on the stack (would be a bug), and only then noticed the >> vload() on the same line. > > > That's my fault... I can take care of it. You never did. I now committed this version: return vload(memcpy(buf, addr, sizeof(vtype))); magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.