Date: Fri, 18 Sep 2015 19:28:29 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: multi-threaded hash table initialization Frank, On Fri, Sep 18, 2015 at 06:03:44PM +0200, Frank Dittrich wrote: > When I just revert 4c541b32c3a02a1fc4981879359307d273c9b9ca, I still > have all jtrts tests fail (with non-OMP). > After reverting 4c541b32c3a02a1fc4981879359307d273c9b9ca and > 4e39b7e608e5bb09624c0b455561c73700e6f24f, the problem goes away. > > If instead ov reverting both of these commits, I just revert > 4e39b7e608e5bb09624c0b455561c73700e6f24f, the bug is still there. Oh, that's weird. These two patches aren't closely related to each other. This means the bug might be somewhere else entirely, or both of these commits might be introducing bugs. It is possible that 4e39b7e608e5bb09624c0b455561c73700e6f24f exposes a bug previously in the codebase. Will you please try to revert only 4c541b32c3a02a1fc4981879359307d273c9b9ca (since it's to be reverted anyway and we're not interested in possible bugs in it) and build with ASan, then run jtrts on that binary? We need to debug 4e39b7e608e5bb09624c0b455561c73700e6f24f or find whatever bug it might have exposed. Thanks, Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.