Date: Fri, 18 Sep 2015 18:45:00 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: multi-threaded hash table initialization On Thu, Sep 17, 2015 at 12:53:23PM +0200, Frank Dittrich wrote: > It also causes a warning for non-OMP builds: I didn't expect magnum would commit this patch after I had called it in here a "failed experiment". Now that it's in there, we should either revert it or fix it for non-OpenMP and benchmark on more systems. I see you're reporting issues with non-OpenMP builds here: https://github.com/magnumripper/JohnTheRipper/commit/9e27b6b60852c2dc594fb895eab65fdbc38ec7fe but it makes no sense to try matching any non-OpenMP build issue to any other patch until the obvious bugs in the "multi-threaded hash table initialization" commit are fixed (or it is reverted). FWIW, in an OpenMP-enabled build it works fine for me. ;-) Just provides arguably too little speedup to be worth it (and might actually hurt performance on CPUs with turbo, etc.) Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.