Date: Thu, 17 Sep 2015 22:26:22 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: dyna_salt_init() Jim - You're calling dyna_salt_init() from two places in loader.c, and neither looks like the most appropriate place to me. One of these is in ldr_load_pw_line(), so it might have performance impact (even though the function is trivial). I think you should be calling dyna_salt_init() near the calls to fmt_init() instead. If you feel you must call it per line processed (why?), consider making it a macro. Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.