Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Wed, 16 Sep 2015 22:40:03 +0200
From: magnum <john.magnum@...hmail.com>
To: john-dev@...ts.openwall.com
Subject: Re: ldr_split_line() performance regression

On 2015-09-16 22:31, magnum wrote:
> On 2015-09-16 22:25, Solar Designer wrote:
>>>> We could also use strnlen() there, if we depend on it elsewhere in the
>>>> jumbo tree anyway.
>>>
>>> Fully agree to that.  If it must be used, then do it early, and use the
>>> results.
>>
>> OK, I'll let you and magnum sort it out.
>>
>> In core, I won't currently commit a version with strnlen(), though.
>
> Just for the record, we don't exactly "depend" on strnlen in Jumbo. If
> it's not available natively, we simply supply our own. We do just this
> for a whole *lot* of little things now and most of it is in jumbo.[ch].
> I think/hope we are almost as portable as John Proper (in a few cases
> actually more portable), except we more or less depend on gmake.

BTW to complete that picture, we do still support "legacy Makefile" 
builds (checked/fixed now and then, mostly by Frank), but that means AC 
is out of the picture. So we won't have things like HAVE_STRNLEN and all 
bets are off.

magnum

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.