Openwall GNU/*/Linux - a small security-enhanced Linux distro for servers
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Wed, 16 Sep 2015 14:02:34 -0500
From: jfoug <jfoug@...nwall.net>
To: john-dev@...ts.openwall.com
Subject: Re: ldr_split_line() performance regression


On 9/16/2015 1:52 PM, Solar Designer wrote:
> strlen(*ciphertext) < 10 && strncmp(*ciphertext, "$dummy$", 7)) {

These should be reversed, since strncmp should short circuit out much 
earlier than the length check.  Also, checking for a '$' char even 
before a strncpy (or even '$' and 'd') would be smart, as would checking 
the 6 byte string "dummy$' from offset 1.

Powered by blists - more mailing lists

Your e-mail address:

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.