Date: Wed, 16 Sep 2015 03:16:35 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: ldr_split_line() performance regression magnum - There's some ridiculous stuff in ldr_split_line() in jumbo now, such as repeated uses of cfg_get_bool(). This (or/and something else) made JtR unusably slow for me when not forcing a specific format. Just try running it on pw-fake-unix from: http://openwall.info/wiki/john/sample-hashes#Sample-password-hash-files without requesting any format. It takes tens of seconds to load that tiny file now, which was previously loaded instantly. Please keep any non-trivial processing out of ldr_split_line(), or at least limit it to only be done once (e.g., by using static variables). Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.