[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 24 Aug 2015 09:15:25 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: testing every index (Re: more robustness)
On Mon, Aug 24, 2015 at 4:04 AM, Frank Dittrich
<frank.dittrich@...lbox.org> wrote:
> On 08/23/2015 03:28 PM, Kai Zhao wrote:
>> Yes. After swap the 5th and 7th, the --test-full could not detect this problem.
>> Should we commit this change ?
>>
>> diff --git a/src/AFS_fmt.c b/src/AFS_fmt.c
>> index 01bd3ad..3f2507e 100644
>> --- a/src/AFS_fmt.c
>> +++ b/src/AFS_fmt.c
>> @@ -33,9 +33,9 @@ static struct fmt_tests tests[] = {
>> {"$K4$d9e985b36268f168,01234567", "U*U***U"},
>> {"$K4$b9615786dfb53297,longcellname", "longpassword"},
>> {"$K4$a8dc8aeaa2c48a97,", ""},
>> - {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
>> {"$K4$e3e59de6f1d5eaf4,cell", "password355"},
>> {"$K4$b02cc24aefbc865b,", "thisisaverylongpassword"},
>> + {"$K4$dfda85c7619183a2,XXXXXXXX", "XXXXXXXX"},
>> {NULL}
>> };
>
> I would love to see your finding documented in a comment, edxplaining
> why you changed the sequence of tests.
Thanks, get it.
Kai
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
