Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 22 Aug 2015 12:27:58 +0800
From: Kai Zhao <>
Subject: Re: testing every index (Re: more robustness)

Hi Alexander,

On Sat, Aug 22, 2015 at 10:42 AM, Solar Designer <> wrote:
> Out of the two if's above, the second one is unneeded: we'll have an
> equivalent of it in cmp_*(), and it will actually affect things there.
> So the memcpy() within the first "if" block should be performed all the
> time.  And then you need to add an "else" branch for the (only
> remaining) outer "if", and simply zeroize the 16 bytes of
> crypt_out[index] there.
> Please make these changes.  Does the format still pass tests with the
> changes?  Does your --test-full problem go away, with no new problems
> appearing?  If so, please make a pull request.

Yes. The vnc still pass tests with this changes. And the --test-full problem
goes away, with no new problems.

Pull request Created:



Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.