[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 22 Aug 2015 00:26:42 +0800
From: Kai Zhao <loverszhao@...il.com>
To: john-dev@...ts.openwall.com
Subject: Re: The cmp_all() of cq
On Sat, Aug 22, 2015 at 12:23 AM, JimF <jfoug@....net> wrote:
> On Fri, 21 Aug 2015 11:14:57 -0500, Kai Zhao <loverszhao@...il.com> wrote:
>
>> The cmp_all() of cq seems never return 0. Is this right ?
>>
>> static int cmp_all(void *binary, int count)
>> {
>> int i = 0;
>>
>> #if defined(_OPENMP) || MAX_KEYS_PER_CRYPT > 1
>> for (i = 0; i < count; ++i)
>> #endif
>> {
>> if ((*(unsigned int*)binary) == *(unsigned
>> int*)crypt_key[i])
>> return 1;
>> }
>>
>> return count;
>> }
>
>
> That looks like a bug to me. self-test does not catch this?!
The original --test did not catch this. The new --test-full option
catches this.
Thanks,
Kai
Powered by blists - more mailing lists
Confused about mailing lists and their use?
Read about mailing lists on Wikipedia
and check out these
guidelines on proper formatting of your messages.
