|
Message-ID: <op.x3lfbwnc3qx92w@mom-laptop> Date: Tue, 18 Aug 2015 21:17:46 -0500 From: "jfoug@....net" <jfoug@....net> To: john-dev@...ts.openwall.com Subject: Re: FMT_OMP_BAD On Tue, 18 Aug 2015 19:51:09 -0500, Solar Designer <solar@...nwall.com> wrote: > On Wed, Aug 19, 2015 at 08:37:27AM +0800, Kai Zhao wrote: >> On Wed, Aug 19, 2015 at 8:34 AM, Solar Designer <solar@...nwall.com> >> wrote: >> And I am trying to add more test vectors for those formats whose >> the number of test vectors is small than 2. > > You should consider the effective number of test vectors, not just the > number of test vectors listed. For example, this: > > static struct fmt_tests haval_128_4_tests[] = { > {"EE6BBF4D6A46A679B3A856C88538BB98", ""}, > {"$haval$ee6bbf4d6a46a679b3a856c88538bb98", ""}, > {NULL} > }; > > is effectively just one test vector, not two. It's just testing two > different encodings. Similarly, haval_256_3_tests[] has 3 encodings of > effectively one test vector. There are probably more cases like this. A lot of these are pretty easy to make, with the -form='dynamic=expr(EEE),debug' method.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.