Date: Wed, 12 Aug 2015 19:23:19 +0800 From: Lei Zhang <zhanglei.april@...il.com> To: john-dev@...ts.openwall.com Subject: Re: Lei's weekly report #15 > On Aug 12, 2015, at 4:50 PM, magnum <john.magnum@...hmail.com> wrote: > > On 2015-08-12 06:12, Lei Zhang wrote: >> >>> On Aug 12, 2015, at 2:39 AM, magnum <john.magnum@...hmail.com> wrote: >>> >>> On 2015-08-10 18:27, Lei Zhang wrote: >>>> I'm still struggling to make episerver work with the SIMD SHA1/2 functions. Magnum, could you take a look at my code? >>>> https://github.com/zzlei/JohnTheRipper/blob/sha2/src/episerver_fmt_plug.c <https://github.com/zzlei/JohnTheRipper/blob/sha2/src/episerver_fmt_plug.c> >>>> I've been tweaking this file hard, but there's still something wrong. Maybe you can notice some obvious mistake in it (?) >>> >>> Attached is a diff against your repo that fixes the problems. There were a few minor (but very effective) bugs and I did a few other changes for clarity. Try to understand the bug fixes fully. >>> >>> Also, now you should move the "write salt to SIMD buffer" from crypt_all() to set_salt(). I believe that will boost the "Many salts" benchmark figure a lot. >> >> I just experimented with that, but got no noticeable change in performance. > > Maybe it's hidden by OMP. It should still be the way I said unless you can explain a sensible reason why not. > > BTW after fixing everything else I said need to be done, you need to handle encodings. Your current code only handles ISO-8859-1 (so I dropped FMT_UTF8 in that patch). It's done now. But how do I test it? The current test vectors don't cover UTF8 encodings. Lei
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.