Date: Thu, 2 Jul 2015 21:04:08 +0200 From: Frank Dittrich <frank.dittrich@...lbox.org> To: john-dev@...ts.openwall.com Subject: Re: Makefile.legacy On 07/01/2015 06:17 PM, Solar Designer wrote: > Oh, I just found this commit: > > commit cd510d4bc5c42d7cd1f99064dd7456888b6a7507 > Author: Frank Dittrich <frank.dittrich@...lbox.org> > Date: Wed Jun 11 23:08:10 2014 +0200 > > Makefile.legacy: avoid make warnings for generic builds > > Compiling: DES benchmark (code version #1) > make: Entering directory `/home/fd/git/JtR/src' > make: warning: jobserver unavailable: using -j1. Add `+' to parent make rule. > > Instead of adding '+' to the "parent" make rule I passed -j1 to ./best.sh > > And it looks bad to me. Please revert it. > > There's no need to explicitly pass the -j value to the subprocesses: > make manages this on its own (via the MAKEFLAGS env var). I just pushed commit 6b0758ffa7b1a463642c5a92f250577ef7229209. It fixes the -j handling for generic builds and other build targets. Frank
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.