Date: Mon, 11 May 2015 23:52:25 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: ./john --test=2xxxxx On 2015-05-11 23:38, Aleksey Cherepanov wrote: > On Mon, May 11, 2015 at 11:27:25PM +0200, Frank Dittrich wrote: >> Options that expect integer values shouldn't allow garbage values. > > BTW --field-separator-char= option falls back to : silently if there > is more than 1 byte of argument. > > With Latin 'a': > $ john --show=left --field-separator-char=a ../../t.pw > using field sep char 'a' (0x61) > > With Cyrillic 'а' in utf-8 (2 bytes but looks like Latin 'a'): > $ john --show=left --field-separator-char=а ../../t.pw > [...] > user:1:$LM$aaaaaaaaaaaaaaaa I fixed this one now. It does allow a string because a literal string "tab" or "TAB" is translated to the tab character, and you can also give any ASCII character in the format "\x09". But now it bails with error if some unusable string is used. $ ../run/john --field-separator-char=€ -show test.in trying to use an invalid field separator char: € (must be single byte character) That error message is somewhat ugly (I copied an existing one). Maybe it should be prepended with "Error: ". magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.