Date: Thu, 7 May 2015 14:02:36 +0300 From: Aleksey Cherepanov <lyosha@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: get_binary_*() and get_hash_*() methods On Thu, May 07, 2015 at 12:50:33PM +0300, Aleksey Cherepanov wrote: > Does john always use binary_hash() methods before cmp_all()? Ouch, I meant get_hash() here. Sorry! get_hash() should be called for each computed hash, cmp_all() without get_hash() should be called for each loaded hash. It would be possible to remove get_hash() calls if crypt_all returned the values in array: john provides a pointer to array of ints (BTW why not unsigned int?) of length MAX_KEYS_PER_CRYPT to crypt_all(), and crypt_all fills the array with values like from get_hash(). Though the length of array should be a separate field in the format structure because crypt_all() may produce more candidates. Thanks! -- Regards, Aleksey Cherepanov
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.