Date: Wed, 06 May 2015 20:42:39 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: bare tag test works only if the first test hash contains format tag On 2015-05-06 18:41, Aleksey Cherepanov wrote: > On Mon, May 04, 2015 at 11:04:35PM +0300, Aleksey Cherepanov wrote: >> The code works for good bare hashes. But it will work wrong for >> shorter hashes. It fails self tests because $SHA512$ without hex >> part is tried: >> FAILED (promiscuous valid ($SHA512$)) >> >> Interestingly format tag is not part of fmt_main, the tag is extracted >> from self tests matching $ (so the test will not be applied if the tag >> is not in $). > > I think the check of bare format tag is performed only if the first > test hash has the tag. So current raw-sha512 does not get the check. Correct. It was never meant for this. It was specifically created to catch some of Dhiru's systematic bugs in dozens of formats. The formats involved did not have bare hashes at all. Isn't it even called "the Dhiru test"? :-) Or maybe that's another one... magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.