Date: Wed, 6 May 2015 17:28:01 +0300 From: Solar Designer <solar@...nwall.com> To: john-dev@...ts.openwall.com Subject: Re: Undefined behavior in bench.c (null pointer passed as argument 1 to memcpy) On Wed, May 06, 2015 at 02:29:03PM +0200, Frank Dittrich wrote: > The only -fsanitize=undefined error I got from running the test suite > for core john is now this one: > > BSDI_fmt.c:279:37: runtime error: left shift of negative value -21. Patched: http://cvsweb.openwall.com/cgi/cvsweb.cgi/Owl/packages/john/john/src/BSDI_fmt.c.diff?r1=1.26;r2=1.27 although I think we really should redefine ARCH_WORD to be unsigned, introduce a separate signed equivalent (ARCH_SWORD?) for occasional uses where that is needed (bitslice hash comparison comes to mind), and introduce an ARCH_INDEX() like macro into common.h for generic maybe-signed char to unsigned int conversion. Alexander
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.