Follow @Openwall on Twitter for new release announcements and other news
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 5 May 2015 00:23:31 +0300
From: Solar Designer <solar@...nwall.com>
To: john-dev@...ts.openwall.com
Subject: Re: get_key() returning 0 causes self tests to crash

On Mon, May 04, 2015 at 11:10:55PM +0300, Aleksey Cherepanov wrote:
> When get_key() method does
>     return 0;
> self tests crash ungracefully (segfault). I'd expect a message^
> 
> FAILED (get_key() returned NULL)
> 
> like for binary() returning 0.

This may be fine for debugging, but FWIW all those NULL checks are
jumbo-specific.  In the core tree, there's no check for binary()
returning NULL either.

Alexander

Powered by blists - more mailing lists

Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.