Date: Tue, 07 Apr 2015 19:04:25 +0200 From: magnum <john.magnum@...hmail.com> To: john-dev@...ts.openwall.com Subject: Re: Coding Style On 2015-04-07 18:56, Frank Dittrich wrote: > On 04/07/2015 06:01 PM, magnum wrote: >> On 2015-04-07 14:45, Kai Zhao wrote: >>> Do you prepare to kill the rule "tab for indent, space for align" ? >> >> On the contrary I said I'm prepared to kill FOR it. Not literally of >> course - if it turns out I'm the only one here that understands the >> beauty of "tab for indent, space for align", I can live with not >> aligning at all (that is, just indenting one (1) more level). > > Not sure it matters, because others contribute more than I do, but I > also prefer tabs for indentation and spaces for alignment. > And I really got used to the editor's default tab width of 8. > > Regarding line size: I can easily live with 132. 80 is better if you > want to print longer source codes on paper for some reason. > Please avoid splitting stdout or stderr strings to reduce the line size. > It makes grepping just too error prone. You mean things like this? if (john_main_process) fprintf(stderr, "%s%d password hash%s cracked," " %d left\n", total ? "\n" : "", total, total != 1 ? "es" : "", db->password_count); Yes, it might be better to let the lines cross the right "margin". magnum
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.