Date: Thu, 18 Dec 2014 10:00:43 -0600 From: "jfoug" <jfoug@....net> To: <john-dev@...ts.openwall.com> Subject: RE: scrypt > -#ifdef __SSE2__ > +#if defined (__SSE2__) || defined (_MSC_VER) > > (part of the same commit). Doesn't MSVC define __SSE2__ when appropriate? And is it appropriate for us to assume SSE2 whenever we build with MSVC? No one would ever want a new Windows build running on anything older than a Pentium 4? Perhaps this is so, but then wouldn't it be more appropriate to enable the proper compiler flags? Actually, that change (adding _MSC_VER) was done at the time I found the bug. I knew there was a bug, when I went to unify the scrypt types, but did not find it until I could step my way through the code. The define was just left that way. There is no __SSE2__ in VC. There are only a couple places in code where defines like that one are, and I simply handle them one if I ever need to debug code. Most of the other stuff is hidden in sse-intrinsics.h or arch.h and few places use the __SSEx__ macros.
Powered by blists - more mailing lists
Confused about mailing lists and their use? Read about mailing lists on Wikipedia and check out these guidelines on proper formatting of your messages.